If that line of code is in the same spot I think it is, then yeah it should be triggering at least the Debug.Log().

Can you run it with the debug text in the hud to show the current move being played and its frames?
I would think it's possible that the jab is finishing before it hits the landing frames.

Not sure what'd be causing it, but normally if something spawns at 0,0,0 then it didn't have a reference point/position to spawn to - for some reason.

I normally use the OnMove() as a trigger where I set a bool if the event was hit with the specific move I was looking for. Then in my Update() method I check if that bool is set to true, and the currentMove is still the move I'm looking for, and the currentMove.currentFrame is the frame I'm looking for, then do the thing I want on that frame, otherwise if currentMove isn't the move I'm looking for, set the bool to false.

Something along those lines.

Though I'm always worried such script additions might cause desyncs in online matchmaking due to possible non-tracking of such things... I'm still hazy on the online code.

You can use a custom script as long as it inherits from CharacterSelectionScreen

public class MyCustomCharacterSelectScreen : CharacterSelectionScreen {

}

from there you're free to override any of the methods used within CharacterSelectionScreen as you see fit.

You'll find character selection in the OnCharacterSelectionAllowed method. In there, you can follow the comments for each block of code. I'd recommend just copying the method and pasting it in your custom select screen, replacing virtual with override.

public override void OnCharacterSelectionAllowed(int character Index, int player) {

}

But in short, I'd change the this.GoToNextScreen() to some new method that is something like this.StartCostumeSelection() if you're having the user select costume on the same screen, or otherwise if its on a new screen then just alter the Next Screen to be the costume select screen. Most typically, you'd be on the same screen, so it's just best to update/add an if check that doesn't go to next screen until the costume has been selected.

In terms of handling costume selection, there's no one way to do that, but I'd recommend starting with displaying a panel that renders an option for each costume type in an array for the selected character. Then making it so directional changes change the highlighted option, and pressing Button1 selects that outfit array. Then you can store which outfit was selected and use that to help set the player character and its set costume option.

I'm unfamiliar with the use of

script.enabled = true;

So I'd reckon that the way you are using it might be an issue.

Also, a suggestion on cleaning up your code might help in debugging:

        foreach (MoveInfo move in enhancedMoves)
        {
            if (cScript.currentMove.moveName == move.moveName)
            {
                script.enabled = true;
                Debug.Log("CheckIfMoveIsEnhanced");
                break;
            }

            script.enabled = false;
            Debug.Log("CheckIfMoveIsNonEnhanced");
        }

That yields the same result as your previous if/else statement in the loop. In this case I can see a logical pathway that could be causing issues.

For example, let's say that you have a list of two moves in the enhancedMoves array [eMove1 and eMove2].

Now, as long as you're performing eMove1 you shouldn't have an issue.
Where you would have an issue is in performing eMove2.
My understanding occurs because of the following reasons:
    (1) The CheckIfMoveIsEnhanced() method is being called every frame.
    (2) On the first Update() tick (frame) that the eMove2 is being performed, it's going to properly register the script.enabled.
    (3) On every proceeding frame that eMove2 is being performed, it's going to hit `script.enabled = false;` because eMove1 which is checked first is not being performed. This will (I presume) end any functionality of the script being disabled. Then on that same frame it will enable it again but because it was previously disabled it will run the Start() and Awake() functions I believe.

So that's some things I see as problematic code in your current script. Sorry I can't be of much more help at this time.

Looks great so far! It's a feature I'd love to have in my own instance of UFE. Keep up the good work!

I had to reselect my character select after upgrading. You probably have to do so as well since Unity acts weird with upgrades sometimes.

Ouch. I hadn't done parries yet in my 3S like project otherwise i might have caught this earlier as well.

I wonder if you could some how use the move system and combine it with the new feature to be able to set basic moves to use a move file? Like have a move that does nothing, set it to the parry as a move, then have that move cancel on the first frame into the high parry and another link into the low parry with the requirements for each being the designated parry option?

Just trying to help you brainstorm.

Do you have source as well?

Did you run the MapRecorder.scene ?

Any folder that is labeled Resources should be located as a valid path to your movesets.

So you can have for example

\\Assets\Resources\Characters\moveset1
\\Assets\Characters\Karate\Resources\moveset2

So entering

Characters\moveset1

or

moveset2

should work depending on which moveset you want.

What's your character's air hit reaction set to? Are there no errors displayed in the console?